Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip content-type header on unknown types #809

Merged

Commits on Jan 1, 2021

  1. fix: skip content-type header on unknown types

    Fixes webpack#354
    
    * Only set 'Content-Type' header if mime type is known.
    * Remove testing for 'Content-Type' of unknown types.
    * Do not test against `application/octet-stream'.
    
    Unknown media types should have content-type blank. Because
    frameworks handle Content-Types differently, it is not possible to
    standardize testing at the moment. Tests against
    `application/octet-stream` can create false positives with Express
    because of this.
    
    https://tools.ietf.org/html/rfc7231#section-3.1.1.5
    broofa/mime#139
    clshortfuse committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    ee7e198 View commit details
    Browse the repository at this point in the history