New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(serve): refactor code to be more concise #974
chore(serve): refactor code to be more concise #974
Conversation
dcfafa8
to
147fc23
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
The commit message should be |
4ce52ac
to
0d9aa9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change PR title too as @ematipico said
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a little comment on the double array inddex accesses?
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice work!
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
Refactored the serve action handler to a more concise form.
Does this PR introduce a breaking change?
Nope
Other information
N/A