Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(info): adding more functionality to info package #833
feat(info): adding more functionality to info package #833
Changes from 20 commits
242c613
d52396b
754ad92
2f31b5b
2badfd1
227f584
dd8b9f1
89b6aa3
b4bd57e
37e4bc0
385a66f
f4ce1e9
2695ac8
721bd36
696fda8
155a5ed
4d0b9de
c525a79
3e142a4
064750a
cb5e84d
55ca613
f1f0fb1
a1301be
0d70982
71ebc63
b54efd0
c5d50b1
0b88f32
2a893c7
aa03e7d
4ec2b89
339dc2c
e623e0e
4396e73
54d7954
facbbbc
1fe3eb9
4166096
211b2be
9395964
b521aaa
88dc7cd
80abe70
83f038c
b3c98ad
4b3105f
8843786
2e9c758
479df8d
5e043b9
110fa5e
a56e916
d14d878
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the config needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supplying a config from
--config
is great I thinkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the variable
envinfo
. Is it needed in this example?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evenstensberg shall I change the config input to
--config=[PATH]
a flag?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You use these constants inside your commands.ts, so you can keep your code DRY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not getting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum
for your available commands.commands.ts
Basically it's not convenient to have the same string repeated in different places. Create ONE constant and it in those places