Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: stability #4150

Merged
merged 1 commit into from
Apr 12, 2024
Merged

test: stability #4150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/serve/basic/__snapshots__/serve-basic.test.js.snap.devServer4.webpack5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ exports[`basic serve usage should throw error when same ports in multicompiler:
at stack"
`;

exports[`basic serve usage should throw error when same ports in multicompiler: stdout 1`] = `""`;

exports[`basic serve usage should work and log warning on the 'watch' option in a configuration: stderr 1`] = `
"[webpack-cli] No need to use the 'serve' command together with '{ watch: true | false }' or '--watch'/'--no-watch' configuration, it does not make sense.
<i> [webpack-dev-server] Project is running at:
Expand Down
2 changes: 0 additions & 2 deletions test/serve/basic/__snapshots__/serve-basic.test.js.snap.devServer5.webpack5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ exports[`basic serve usage should throw error when same ports in multicompiler:
at stack"
`;

exports[`basic serve usage should throw error when same ports in multicompiler: stdout 1`] = `""`;

exports[`basic serve usage should work and log warning on the 'watch' option in a configuration: stderr 1`] = `
"[webpack-cli] No need to use the 'serve' command together with '{ watch: true | false }' or '--watch'/'--no-watch' configuration, it does not make sense.
<i> [webpack-dev-server] Project is running at:
Expand Down
5 changes: 3 additions & 2 deletions test/serve/basic/serve-basic.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,13 +481,14 @@ describe("basic serve usage", () => {
});

it("should throw error when same ports in multicompiler", async () => {
const { stderr, stdout } = await runWatch(__dirname, [
const { stderr } = await runWatch(__dirname, [
"serve",
"--config",
"same-ports-dev-server.config.js",
]);

expect(normalizeStderr(stderr)).toMatchSnapshot("stderr");
expect(normalizeStdout(stdout)).toMatchSnapshot("stdout");
// Due to racing logic, first dev server can be started and compiled, but then the second always fails
// expect(normalizeStdout(stdout)).toMatchSnapshot("stdout");
});
});