Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bundle analyzer #4131

Closed
wants to merge 12 commits into from
Closed

Conversation

info-arnav
Copy link

Reference #1838

Webpack Bundle Analyzer

The pull request doesnt itself offer any changes yet, just a template for the change I am planning.

I plan on creating an own bundle analyzer for webpack refering to https://github.com/webpack-contrib/webpack-bundle-analyzer

Converting it to typeScript, using webpack modules such as logger and caching and refactoring everything a bit.

Please just let me know if the approach is fine, if yes ill continue with writing the program.

@info-arnav info-arnav requested a review from a team as a code owner March 31, 2024 20:00
@info-arnav info-arnav changed the title Bundle analyzer feat: Bundle analyzer Mar 31, 2024
@info-arnav
Copy link
Author

Reference #1838

Webpack Bundle Analyzer

The pull request doesnt itself offer any changes yet, just a template for the change I am planning.

I plan on creating an own bundle analyzer for webpack refering to https://github.com/webpack-contrib/webpack-bundle-analyzer

Converting it to typeScript, using webpack modules such as logger and caching and refactoring everything a bit.

Please just let me know if the approach is fine, if yes ill continue with writing the program.

@alexander-akait @evenstensberg

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need implement schema for webpack-bundle-analyzer and read options from schema (can be done late)

From #1838 (comment), only the last action item is pending.

I plan on creating an own bundle analyzer for webpack refering to https://github.com/webpack-contrib/webpack-bundle-analyzer. Converting it to typeScript, using webpack modules such as logger and caching and refactoring everything a bit.

This is not required to resolve this issue.

Comment on lines -990 to -1001
{
name: "analyze",
configs: [
{
type: "enum",
values: [true],
},
],
multiple: false,
description: "It invokes webpack-bundle-analyzer plugin to get bundle information.",
helpLevel: "minimum",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of a custom plugin, so was planning on changing stuff accordingly. But got it, will start working on the last action.

@alexander-akait
Copy link
Member

Thank issue should be resolved on webpack-bundle-analyzer, you need to add such stuff https://github.com/webpack/webpack-dev-server/blob/master/bin/cli-flags.js, so webpack-cli reads all CLI flags and provide their to user

@info-arnav
Copy link
Author

will start today

@info-arnav info-arnav closed this Apr 6, 2024
@info-arnav info-arnav deleted the bundle-analyzer branch April 6, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants