Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: failOnWarnings option #3317

Merged
merged 8 commits into from Jun 30, 2022
Merged

feat: failOnWarnings option #3317

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
852bc34
feat: failOnWarnings option
rishabh3112 Jun 29, 2022
a4f0cc1
feat: failOnWarnings option
rishabh3112 Jun 29, 2022
fd72db7
chore: update docs
rishabh3112 Jun 29, 2022
5bfd563
chore: enforce exit on warnings
rishabh3112 Jun 29, 2022
dadf7a9
test: fail on warnings option
rishabh3112 Jun 29, 2022
1dbc0be
chore: change flag type
rishabh3112 Jun 29, 2022
e0fe1a1
chore: no exit on warning and errors
rishabh3112 Jun 29, 2022
aaa1d84
chore: suggestion
rishabh3112 Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/webpack-cli/src/types.ts
View file
Open in desktop
Expand Up @@ -210,6 +210,7 @@ interface WebpackRunOptions extends WebpackOptionsNormalized {
json?: boolean;
argv?: Argv;
env: Env;
failOnWarnings?: boolean;
}

/**
Expand Down
14 changes: 14 additions & 0 deletions packages/webpack-cli/src/webpack-cli.ts
View file
Open in desktop
Expand Up @@ -976,6 +976,16 @@ class WebpackCLI implements IWebpackCLI {
description: "Stop watching when stdin stream has ended.",
negatedDescription: "Do not stop watching when stdin stream has ended.",
},
{
name: "fail-on-warnings",
configs: [
{
type: "boolean",
rishabh3112 marked this conversation as resolved.
Show resolved Hide resolved
},
rishabh3112 marked this conversation as resolved.
Show resolved Hide resolved
],
negative: false,
description: "Stop webpack-cli process on non-zero exit code",
},
];

// Extract all the flags being exported from core.
Expand Down Expand Up @@ -2478,6 +2488,10 @@ class WebpackCLI implements IWebpackCLI {
this.logger.raw(printedStats);
}
}

if (options.failOnWarnings && stats.hasErrors()) {
process.exit(1);
rishabh3112 marked this conversation as resolved.
Show resolved Hide resolved
}
};

const env =
Expand Down