Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init-generator): add svelte template #2859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
N/A

Summary
This PR aims at adding a svelte template for init-generator #2832

Does this PR introduce a breaking change?
No

Other information
N/A

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #2859 (22ee992) into master (d9d4c37) will decrease coverage by 0.29%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2859      +/-   ##
==========================================
- Coverage   95.01%   94.71%   -0.30%     
==========================================
  Files          31       32       +1     
  Lines        1706     1723      +17     
  Branches      498      497       -1     
==========================================
+ Hits         1621     1632      +11     
- Misses         85       91       +6     
Impacted Files Coverage Δ
packages/generators/src/utils/helpers.ts 74.07% <42.85%> (-10.93%) ⬇️
packages/generators/src/handlers/svelte.ts 85.71% <85.71%> (ø)
packages/generators/src/addon-generator.ts 91.83% <100.00%> (-0.76%) ⬇️
packages/generators/src/handlers.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b326f6...22ee992. Read the comment docs.

@jamesgeorge007 jamesgeorge007 marked this pull request as ready for review July 28, 2021 03:23
@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner July 28, 2021 03:23
},
},
{
test: /\.css$/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add support for postcss, sass, etc here. Like we have in default template. Maybe we can have some refactoring here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, ideally we should extend default template and add custom loaders/plugins

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t need this. CWA (create webpack app) is going to be a standalone tool soon. Gsoc project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants