Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install required packages for loading command automatically #2815

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
WIP in tests
If relevant, did you update the documentation?
NA
Summary

#2809 (comment)

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner July 4, 2021 13:18
@snitin315 snitin315 marked this pull request as draft July 4, 2021 13:18
@snitin315
Copy link
Member Author

smoke tests passing locally 😞.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, do you think it is better do for all commands? I think it will be good for init only, but I am fine with install all by default

@snitin315
Copy link
Member Author

Yes, we should do it for all.

@snitin315 snitin315 force-pushed the feat/automatic-install branch 2 times, most recently from 3eeadfb to 5e0441c Compare July 15, 2021 13:01
@snitin315 snitin315 force-pushed the feat/automatic-install branch 3 times, most recently from 0f42643 to 5732d24 Compare July 26, 2021 11:37
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #2815 (88d24d9) into master (3e2bb73) will decrease coverage by 0.08%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2815      +/-   ##
==========================================
- Coverage   95.01%   94.93%   -0.09%     
==========================================
  Files          31       32       +1     
  Lines        1706     1717      +11     
  Branches      498      500       +2     
==========================================
+ Hits         1621     1630       +9     
- Misses         85       87       +2     
Impacted Files Coverage Δ
...kages/webpack-cli/lib/utils/prompt-installation.js 76.92% <71.42%> (+1.92%) ⬆️
packages/webpack-cli/lib/webpack-cli.js 96.87% <100.00%> (+<0.01%) ⬆️
packages/webpack-cli/lib/utils/run-command.js 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2bb73...88d24d9. Read the comment docs.

@snitin315
Copy link
Member Author

snitin315 commented Jul 26, 2021

/cc @webpack/cli-team, Can someone check it locally on Linux/windows, all tests are passing on my macOS. (Missing prettier smoketests specially)

@alexander-akait
Copy link
Member

@snitin315 Do we need this, I just checked and we don't ask about installation when I use webpack init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants