Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #1840

Merged
merged 9 commits into from Oct 4, 2020
Merged

chore: update dependencies #1840

merged 9 commits into from Oct 4, 2020

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
No

If relevant, did you update the documentation?
N/A

Summary
Update dependencies to not be locked.

Does this PR introduce a breaking change?
No

Other information
Another attempt at reducing deps.

@rishabh3112
Copy link
Member Author

Lodash remains unaffected after unlocking deps as well.

evenstensberg
evenstensberg previously approved these changes Sep 28, 2020
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's update and fix any regressions

@alexander-akait
Copy link
Member

/cc @rishabh3112 What is status?

@rishabh3112
Copy link
Member Author

Should I continue working on it? as generators break on unlocking + install size is almost unaffected.

@alexander-akait
Copy link
Member

@rishabh3112 Yes, there is situation when our deps will be vulnerable and to avoid unnecessary patch release we should use ^ everywhere

@rishabh3112
Copy link
Member Author

Blocked by jestjs/jest#10502 to get released

@alexander-akait
Copy link
Member

@rishabh3112 Can you clarify?

@rishabh3112
Copy link
Member Author

@rishabh3112 Can you clarify?

console.Console is unavailable in jest environment while testing, thus CI fails.

@rishabh3112
Copy link
Member Author

jestjs/jest#10282 for more info

@alexander-akait
Copy link
Member

@rishabh3112 Can you give me a link on broken tests, it is blocker for the stable release

@rishabh3112
Copy link
Member Author

rishabh3112 commented Oct 2, 2020

Yes, here are files

  • packages/generators/__tests__/utils/languageSupport.test.ts
  • packages/generators/__tests__/utils/styleSupport.test.ts
  • packages/generators/__tests__/addon-generator.test.ts

The problem is yeoman-environment creates new environment for a generator. But when it's .createEnv() function is called, new console.Console() is called in a nested file which leads to this.

And here is link to CI build: https://github.com/webpack/webpack-cli/pull/1840/checks?check_run_id=1169132990

@alexander-akait
Copy link
Member

@rishabh3112 Let's skip them with todo, manually testing and solve it late

@rishabh3112
Copy link
Member Author

rishabh3112 commented Oct 2, 2020

/cc @evilebottnawi

Tests are passing now.
Regarding skipped tests, haven't emulated unit tests manually though but the major dependent features (e.g. init) are working.

@alexander-akait
Copy link
Member

@rishabh3112 looks good, I am afraid init can be broken, so I want to check it manually

@rishabh3112
Copy link
Member Author

rishabh3112 commented Oct 2, 2020

I have checked init manually, it is working fine for me.
I will ping others on slack, to see if someone else can confirm as well.

@rishabh3112 rishabh3112 marked this pull request as ready for review October 3, 2020 03:07
@rishabh3112 rishabh3112 requested a review from a team as a code owner October 3, 2020 03:07
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@webpack-bot
Copy link

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@rishabh3112
Copy link
Member Author

CI is green, merging.

@rishabh3112 rishabh3112 merged commit 3efbaf4 into next Oct 4, 2020
@rishabh3112 rishabh3112 deleted the chore/update-deps branch October 4, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants