New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #1840
Conversation
Lodash remains unaffected after unlocking deps as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's update and fix any regressions
/cc @rishabh3112 What is status? |
Should I continue working on it? as generators break on unlocking + install size is almost unaffected. |
@rishabh3112 Yes, there is situation when our deps will be vulnerable and to avoid unnecessary patch release we should use |
Blocked by jestjs/jest#10502 to get released |
@rishabh3112 Can you clarify? |
|
jestjs/jest#10282 for more info |
@rishabh3112 Can you give me a link on broken tests, it is blocker for the stable release |
Yes, here are files
The problem is And here is link to CI build: https://github.com/webpack/webpack-cli/pull/1840/checks?check_run_id=1169132990 |
@rishabh3112 Let's skip them with todo, manually testing and solve it late |
/cc @evilebottnawi Tests are passing now. |
@rishabh3112 looks good, I am afraid init can be broken, so I want to check it manually |
I have checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
CI is green, merging. |
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
No
If relevant, did you update the documentation?
N/A
Summary
Update dependencies to not be locked.
Does this PR introduce a breaking change?
No
Other information
Another attempt at reducing deps.