feat: add support to spawn multiple compilers with different configs #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anshumanv
changed the title
evenstensberg
previously approved these changes
Aug 23, 2020
alexander-akait
previously approved these changes
Aug 24, 2020
snitin315
previously approved these changes
Aug 24, 2020
rishabh3112
reviewed
Aug 24, 2020
rishabh3112
previously approved these changes
Aug 24, 2020
anshumanv
commented
Aug 24, 2020
anshumanv
dismissed stale reviews from rishabh3112, snitin315, alexander-akait, and evenstensberg
via
2d874d8
Co-authored-by: Rishabh Chawla <rishabh31121999@gmail.com>
anshumanv
force-pushed
the
multi-config
branch
from
3ee02c8
to
a42692d
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
alexander-akait
approved these changes
Aug 24, 2020
rishabh3112
approved these changes
Aug 24, 2020
|
/cc @webpack/cli-team |
snitin315
approved these changes
Aug 24, 2020
|
/cc @evenstensberg |
evenstensberg
approved these changes
Aug 25, 2020
|
Merging, thanks for the feedback everyone! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
yes
Summary
webpack([{...}, {...}])which spawn multiple compilersDoes this PR introduce a breaking change?
No
Other information