Always spawn a process for cli #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack-bot
added
PR: unreviewed
PR: CI-not-ok
PR: CI-ok
and removed
PR: CI-not-ok
labels
ematipico
reviewed
Feb 3, 2020
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
approved these changes
Feb 3, 2020
29 tasks
jamesgeorge007
approved these changes
Feb 3, 2020
alexander-akait
approved these changes
Feb 4, 2020
anshumanv
reviewed
Feb 16, 2020
| @@ -1,7 +1,8 @@ | |||
| import { join } from 'path'; | |||
| import { run } from 'yeoman-test'; | |||
|
|
|||
| describe('init generator', () => { | |||
| // fixme: unstable | |||
There was a problem hiding this comment.
Is this a flaky test? Seems to pass locally.
There was a problem hiding this comment.
Locally but on Travis it times out
There was a problem hiding this comment.
Maybe we can increase the timeout for these tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
closes #1084
Did you add tests for your changes?
no
If relevant, did you update the documentation?
no
Summary
Always spawn a process for cli
Does this PR introduce a breaking change?
no