Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(generators): send warning regarding invalid template to stderr #2687

Merged
merged 2 commits into from May 5, 2021

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented May 3, 2021

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
Update test suite.

If relevant, did you update the documentation?
N/A

Summary

this.utils.logger.warn(`⚠ ${this.template} is not a valid template, please select one from below`);

Does this PR introduce a breaking change?
Nope

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner May 3, 2021 11:03
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #2687 (99e87ff) into master (af6c02b) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
- Coverage   96.06%   96.00%   -0.07%     
==========================================
  Files          30       30              
  Lines        1526     1526              
  Branches      432      432              
==========================================
- Hits         1466     1465       -1     
- Misses         60       61       +1     
Impacted Files Coverage Δ
packages/generators/src/init-generator.ts 98.07% <100.00%> (ø)
packages/generators/src/addon-generator.ts 91.22% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6c02b...99e87ff. Read the comment docs.

@jamesgeorge007 jamesgeorge007 changed the title chore(generators): send warning regarding invalid template to stdout chore(generators): send warning regarding invalid template to stderr May 5, 2021
@alexander-akait alexander-akait merged commit dc0481b into master May 5, 2021
@alexander-akait alexander-akait deleted the invalid-template-log branch May 5, 2021 13:01
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes without explicit approval. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants