chore: send warnings to stderr

webpack · May 5, 2021 · 99e87ff · 99e87ff
1 parent 7a0f4d8
commit 99e87ff
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/packages/generators/src/addon-generator.ts b/packages/generators/src/addon-generator.ts
@@ -1,4 +1,3 @@
-import { yellow } from 'colorette';
 import fs from 'fs';
 import path from 'path';
 import Generator from 'yeoman-generator';
@@ -58,7 +57,7 @@ const addonGenerator = (
 
         public async prompting(): Promise<void> {
             if (!this.supportedTemplates.includes(this.template)) {
-                this.utils.logger.log(`${yellow(`⚠ ${this.template} is not a valid template, please select one from below`)}`);
+                this.utils.logger.warn(`⚠ ${this.template} is not a valid template, please select one from below`);
 
                 const { selectedTemplate } = await List(
                     this,

diff --git a/packages/generators/src/init-generator.ts b/packages/generators/src/init-generator.ts
@@ -58,7 +58,7 @@ export default class InitGenerator extends CustomGenerator {
         }
 
         if (!this.supportedTemplates.includes(this.template)) {
-            this.utils.logger.log(`${yellow(`⚠ ${this.template} is not a valid template, please select one from below`)}`);
+            this.utils.logger.warn(`⚠ ${this.template} is not a valid template, please select one from below`);
 
             const { selectedTemplate } = await Question.List(
                 this,

diff --git a/test/init/init.test.js b/test/init/init.test.js
@@ -112,7 +112,7 @@ describe('init command', () => {
         const { stdout, stderr } = await runPromptWithAnswers(assetsPath, ['init', '--force', '--template=apple'], [`${ENTER}`]);
 
         expect(stdout).toContain('Project has been initialised with webpack!');
-        expect(stdout).toContain('apple is not a valid template, please select one from below');
+        expect(stderr).toContain('apple is not a valid template, please select one from below');
         expect(stderr).toContain('webpack.config.js');
 
         // Test files

diff --git a/test/loader/loader.test.js b/test/loader/loader.test.js
@@ -147,8 +147,8 @@ describe('loader command', () => {
 
     it('should prompt on supplying an invalid template', async () => {
         const assetsPath = await uniqueDirectoryForTest();
-        const { stdout } = await runPromptWithAnswers(assetsPath, ['loader', '--template=unknown']);
+        const { stderr } = await runPromptWithAnswers(assetsPath, ['loader', '--template=unknown']);
 
-        expect(stdout).toContain('unknown is not a valid template');
+        expect(stderr).toContain('unknown is not a valid template');
     });
 });
diff --git a/test/plugin/plugin.test.js b/test/plugin/plugin.test.js
@@ -136,8 +136,8 @@ describe('plugin command', () => {
 
     it('should prompt on supplying an invalid template', async () => {
         const assetsPath = await uniqueDirectoryForTest();
-        const { stdout } = await runPromptWithAnswers(assetsPath, ['plugin', '--template=unknown']);
+        const { stderr } = await runPromptWithAnswers(assetsPath, ['plugin', '--template=unknown']);
 
-        expect(stdout).toContain('unknown is not a valid template');
+        expect(stderr).toContain('unknown is not a valid template');
     });
 });