refactor: rm duplication

webpack · Sep 18, 2020 · 8cbf376 · 8cbf376
1 parent 6b44fe9
commit 8cbf376
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/packages/webpack-cli/lib/groups/ConfigGroup.js b/packages/webpack-cli/lib/groups/ConfigGroup.js
@@ -127,11 +127,6 @@ class ConfigGroup extends GroupHelper {
             newOptionsObject['options'] = configOptions;
         }
 
-        //warn the user if bail and watch both are used together
-        if (configOptions.bail && configOptions.watch) {
-            logger.warn('You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.');
-        }
-
         if (configOptions && configPath.includes('.webpack')) {
             const currentPath = configPath;
             const parentContext = dirname(currentPath).split(sep).slice(0, -1).join(sep);

diff --git a/packages/webpack-cli/lib/utils/Compiler.js b/packages/webpack-cli/lib/utils/Compiler.js
@@ -118,7 +118,7 @@ class Compiler {
         }
 
         //warn the user if bail and watch both are used together
-        if (this.compiler.options.bail && outputOptions.watch) {
+        if (this.compiler.options.bail && (outputOptions.watch || options.watch)) {
             logger.warn('You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.');
         }