feat: add support for .cjs config (#1727)

* feat: support .cjs config file * feat: support .cjs config file * feat: support .cjs config file
webpack · Aug 5, 2020 · 55ab016 · 55ab016
1 parent c8e1dfe
commit 55ab016
Show file tree

Hide file tree

Showing 8 changed files with 37 additions and 1 deletion.
diff --git a/packages/webpack-cli/lib/groups/ConfigGroup.js b/packages/webpack-cli/lib/groups/ConfigGroup.js
@@ -42,6 +42,16 @@ const getDefaultConfigFiles = () => {
 
 const getConfigInfoFromFileName = (filename) => {
     const fileMetaData = parse(filename);
+    // .cjs is not available on interpret side, handle it manually for now
+    if (filename.endsWith('.cjs')) {
+        return [
+            {
+                path: resolve(filename),
+                ext: '.cjs',
+                module: null,
+            },
+        ];
+    }
     return Object.keys(extensions)
         .filter((ext) => ext.includes(fileMetaData.ext))
         .filter((ext) => fileMetaData.base.substr(fileMetaData.base.length - ext.length) === ext)

diff --git a/test/config-format/commonjs/commonjs.test.js b/test/config-format/commonjs/commonjs.test.js
@@ -0,0 +1,12 @@
+const { run } = require('../../utils/test-utils');
+const { existsSync } = require('fs');
+const { resolve } = require('path');
+
+describe('webpack cli', () => {
+    it('should support CommonJS file', () => {
+        const { stderr, stdout } = run(__dirname, ['-c', 'webpack.config.cjs'], false);
+        expect(stderr).toBeFalsy();
+        expect(stdout).toBeTruthy();
+        expect(existsSync(resolve(__dirname, 'dist/foo.bundle.js'))).toBeTruthy();
+    });
+});
diff --git a/test/config-format/commonjs/main.js b/test/config-format/commonjs/main.js
@@ -0,0 +1 @@
+console.log('Hoshiumi');
diff --git a/test/config-format/commonjs/webpack.config.cjs b/test/config-format/commonjs/webpack.config.cjs
@@ -0,0 +1,12 @@
+const path = require('path');
+
+const config = {
+    mode: 'production',
+    entry: './main.js',
+    output: {
+        path: path.resolve(__dirname, 'dist'),
+        filename: 'foo.bundle.js',
+    },
+};
+
+module.exports = config;
diff --git a/test/typescript/main.ts → test/config-format/typescript/main.ts b/test/typescript/main.ts → test/config-format/typescript/main.ts
diff --git a/test/typescript/package.json → test/config-format/typescript/package.json b/test/typescript/package.json → test/config-format/typescript/package.json
diff --git a/test/typescript/typescript.test.js → ...nfig-format/typescript/typescript.test.js b/test/typescript/typescript.test.js → ...nfig-format/typescript/typescript.test.js
@@ -1,6 +1,6 @@
 /* eslint-disable   node/no-missing-require */
 /* eslint-disable   node/no-unpublished-require */
-const { run, runInstall } = require('../utils/test-utils');
+const { run, runInstall } = require('../../utils/test-utils');
 const { stat } = require('fs');
 const { resolve } = require('path');
 

diff --git a/test/typescript/webpack.config.ts → ...onfig-format/typescript/webpack.config.ts b/test/typescript/webpack.config.ts → ...onfig-format/typescript/webpack.config.ts
@@ -1,3 +1,4 @@
+/* eslint-disable node/no-unsupported-features/es-syntax */
 /** eslint-disable **/
 import * as path from 'path';