Skip to content

Commit

Permalink
fix: conlicts
Browse files Browse the repository at this point in the history
  • Loading branch information
snitin315 committed Oct 4, 2020
1 parent 581be29 commit 3047771
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
21 changes: 20 additions & 1 deletion packages/webpack-cli/lib/groups/resolveAdvanced.js
@@ -1,9 +1,13 @@
const { packageExists } = require('@webpack-cli/package-utils');
const { yellow } = require('colorette');
const { error } = require('../utils/logger');

/**
* Resolve advanced flags
* @param {args} args - Parsed args passed to CLI
*/
const resolveAdvanced = (args) => {
const { target, prefetch, hot } = args;
const { target, prefetch, hot, analyze } = args;

const finalOptions = {
options: {},
Expand All @@ -28,6 +32,21 @@ const resolveAdvanced = (args) => {
finalOptions.options.plugins = [prefetchVal];
}
}
if (analyze) {
if (packageExists('webpack-bundle-analyzer')) {
// eslint-disable-next-line node/no-extraneous-require
const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
const bundleAnalyzerVal = new BundleAnalyzerPlugin();
if (finalOptions.options && finalOptions.options.plugins) {
finalOptions.options.plugins.unshift(bundleAnalyzerVal);
} else {
finalOptions.options.plugins = [bundleAnalyzerVal];
}
} else {
error(`It looks like ${yellow('webpack-bundle-analyzer')} is not installed.`);
process.exitCode = 2;
}
}
if (target) {
finalOptions.options.target = args.target;
}
Expand Down
1 change: 0 additions & 1 deletion packages/webpack-cli/lib/utils/cli-flags.js
Expand Up @@ -222,7 +222,6 @@ const core = [
usage: '--analyze',
type: Boolean,
multiple: false,
group: ADVANCED_GROUP,
description: 'It invokes webpack-bundle-analyzer plugin to get bundle information',
},
/* {
Expand Down

0 comments on commit 3047771

Please sign in to comment.