Skip to content

Commit

Permalink
fix: apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesgeorge007 committed Jul 29, 2020
1 parent f7bd481 commit 1b9f555
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/webpack-cli/lib/utils/cli-flags.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const ADVANCED_GROUP = 'advanced';
const DISPLAY_GROUP = 'stats';
const ZERO_CONFIG_GROUP = 'zero-config';

// Extract all the flages being exported from core. A list of cli flags generated by core
// Extract all the flags being exported from core. A list of cli flags generated by core
// can be found here https://github.com/webpack/webpack/blob/master/test/__snapshots__/Cli.test.js.snap
let flagsFromCore =
typeof cli !== 'undefined'
Expand Down Expand Up @@ -273,5 +273,5 @@ module.exports = {
group: BASIC_GROUP
} */
],
flagsFromCore: flagsFromCore,
flagsFromCore,
};
2 changes: 1 addition & 1 deletion test/core-flags/module-flags.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const { run, hyphenToUpperCase } = require('../utils/test-utils');
const { flagsFromCore } = require('../../packages/webpack-cli/lib/utils/cli-flags');
//--module-rules-options will be exluded for cli.
//--module-rules-options will be excluded for cli.
const moduleFlags = flagsFromCore.filter(({ name }) => name.startsWith('module-') && name !== 'module-rules-options');

describe('module config related flag', () => {
Expand Down

0 comments on commit 1b9f555

Please sign in to comment.