Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix instability in polling tests #206

Merged
merged 1 commit into from Nov 24, 2021

Conversation

markjm
Copy link
Contributor

@markjm markjm commented Nov 17, 2021

Fix the instability in polling tests with pausing the watcher due to multiple ticks in the same polling interval.

This will cause the test passes of #205 and #197 to complete successfully.

cc @alexander-akait

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #206 (d7b98c5) into master (c651129) will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   92.67%   92.19%   -0.49%     
==========================================
  Files           6        6              
  Lines        1038     1038              
  Branches      245      245              
==========================================
- Hits          962      957       -5     
- Misses         76       81       +5     
Flag Coverage Δ
integration 92.19% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/DirectoryWatcher.js 91.93% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c651129...d7b98c5. Read the comment docs.

@sokra sokra merged commit 12f5ebc into webpack:master Nov 24, 2021
@sokra
Copy link
Member

sokra commented Nov 24, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants