New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow function in watchOptions.ignored
#197
Conversation
Related to discussion post here webpack/webpack#13566 |
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 92.67% 91.80% -0.88%
==========================================
Files 6 6
Lines 1038 1037 -1
Branches 245 245
==========================================
- Hits 962 952 -10
- Misses 76 85 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test case?
8bcee15
to
ee9a8e3
Compare
@alexander-akait done - thanks for the suggestion, because I found an issue with the test I wrote. Tests +1 / Hubris +0 |
@alexander-akait ive patched this into our project and have been using it. Also had an unexpected performance improvement because I was able to tailor the regexs we use to be more performant than the globtoregex regexs :) |
ee9a8e3
to
a05d00d
Compare
a05d00d
to
a609db9
Compare
@sokra / @alexander-akait - I have reworked these changes to simply allow a custom test function instead of trying to mess with provided regex's and flags. Now you can simply provide a function to ignore, which I can document on webpack side as well. |
CI is broken |
watchOptions.ignored
watchOptions.ignored
a609db9
to
c651129
Compare
cc5b141
to
08f6a1a
Compare
@alexander-akait i think the test may be flaky because (1) the test is working in various polling/non-polling matrix entries, (2) #203 (just some other arbitrary PR) sees the same test failing in random stages as well, and (3) the failure does not repro for me locally. Please let me know if I am doing something wrong here |
move path normalization to option normalization
The globs are turned into regex's anyway, so seems like a pretty simple change. Have a webpack discussion thread on the topic as well where I suggest aligning
watchOptions.ignored
andWatchIgnorePlugin