Migrate Loader Utils to TypeScript #235
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
reviewed
Dec 23, 2022
lib/getHashDigest.ts
Outdated
| } | ||
| } | ||
|
|
||
| hash = new BatchedHash(createXXHash64()); | ||
| hash = new BatchedHash(createXXHash64() as unknown as Hash); |
There was a problem hiding this comment.
This cast is unfortunate. Can it be elimianted?
There was a problem hiding this comment.
createXXHash64() & createMd4() is of type WasmHash and I'm having a hard time understanding the best way to 'coerce' these together to be typed properly. Advice here is welcomed.
| @@ -0,0 +1,35 @@ | |||
| import path from "path"; | |||
There was a problem hiding this comment.
Consider renaming this in a separate commit to retain the history.
|
@sokra adding you on this review. I'd like some advice on how we'd align the classes between WasmHash instances and regular Hash instances so this is more typesafe. |
Clean up some hash typings.
|
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Remove types from JSDoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#234