Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated String.prototype.substr() #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CommanderRoot
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Breaking Changes

None

Additional Info

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #207 (24f1b73) into master (9fe2381) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          10       10           
  Lines         360      360           
  Branches      112      112           
=======================================
  Hits          276      276           
  Misses         73       73           
  Partials       11       11           
Impacted Files Coverage Δ
lib/interpolateName.js 95.00% <66.66%> (ø)
lib/getHashDigest.js 89.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe2381...24f1b73. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant