Skip to content
This repository has been archived by the owner on Sep 9, 2021. It is now read-only.

fix: make inline workers work from IE/Edge legacy #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elasim
Copy link

@elasim elasim commented May 11, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

No breaking changes.

Additional Info

N/A

Schedule object url revoking when setImmediate is available.
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #316 (3b1e9d2) into master (22275e9) will decrease coverage by 22.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #316       +/-   ##
===========================================
- Coverage   75.83%   53.64%   -22.20%     
===========================================
  Files           6        6               
  Lines         149      151        +2     
  Branches       52       53        +1     
===========================================
- Hits          113       81       -32     
- Misses         30       54       +24     
- Partials        6       16       +10     
Impacted Files Coverage Δ
src/runtime/inline.js 0.00% <0.00%> (ø)
src/supportWebpack5.js 0.00% <0.00%> (-83.34%) ⬇️
src/index.js 82.50% <0.00%> (-12.50%) ⬇️
src/utils.js 81.57% <0.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22275e9...3b1e9d2. Read the comment docs.

@alexander-akait
Copy link
Member

Can you accept CLA?

@elasim
Copy link
Author

elasim commented May 11, 2021

Okay. I accepted CLA.

@alexander-akait
Copy link
Member

I will fix tests tomorrow and do release

@elasim
Copy link
Author

elasim commented May 11, 2021

Good. Thanks for your efforts.

@elasim
Copy link
Author

elasim commented May 11, 2021

I've found a minor glitch for this approach.

#292 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants