Skip to content

Commit

Permalink
fix(package): copy existing bin property (#108)
Browse files Browse the repository at this point in the history
  • Loading branch information
shellscape authored and joshwiens committed Apr 2, 2018
1 parent b3b0989 commit de92db1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/tasks/package.js
@@ -1,5 +1,6 @@
/* eslint-disable no-template-curly-in-string */
const path = require('path');

const meta = require('user-meta');
const gitUsername = require('git-username');
const { json, install } = require('mrm-core');
Expand Down Expand Up @@ -61,6 +62,7 @@ module.exports = (config) => {
author: existing.author || `${name}`,
homepage: `https://github.com/${repository}`,
bugs: `https://github.com/${repository}/issues`,
bin: existing.bin || '',

This comment has been minimized.

Copy link
@EECOLOR

EECOLOR Nov 24, 2018

The default value here is problematic: webpack-contrib/url-loader#163

I don't know what default value to set in order for the mrm-core to ignore the key and omit it.

This comment has been minimized.

Copy link
@alexander-akait

alexander-akait Nov 24, 2018

Member

@EECOLOR you are right, we should fix it, feel free to send a PR with remove bin

main: existing.main || 'dist/cjs.js',
engines: {
node: `>= ${config.maintLTS} || >= ${config.activeLTS}`,
Expand Down

0 comments on commit de92db1

Please sign in to comment.