Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sirv to fix analyzerMode server #611

Merged
merged 2 commits into from Aug 30, 2023

Conversation

panbenson
Copy link
Contributor

i'm unable to start webpack-bundle-analyzer@4.9.0 in 'server' mode with the following traceback:

node_modules/webpack-bundle-analyzer/lib/viewer.js:89
      sirvMiddleware(req, res);
      ^
TypeError: parser is not a function
    at node_modules/webpack-bundle-analyzer/node_modules/sirv/build.js:163:30
    at Server.<anonymous> (node_modules/webpack-bundle-analyzer/lib/viewer.js:89:7)
    at Server.emit (node:events:513:28)
    at Server.emit (node:domain:489:12)
    at parserOnIncoming (node:_http_server:1068:12)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)

it appears to be related to sirv, and a fix for this issue (lukeed/sirv#124) was released in ^2.0.0. i've confirmed adding a resolution for this package lets me boot webpack-bundle-analyzer in 'server' mode on my project.

also ran npm test locally with these changes

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Would you be able to update the CHANGELOG.md as well?

@panbenson
Copy link
Contributor Author

@valscion added an entry in the changelog, let me know if that works!

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Thank you for the good PR description, it was helpful to see what fixes inside sirv this upgrade incorporated.

@valscion valscion merged commit a0e04ef into webpack-contrib:master Aug 30, 2023
6 checks passed
@valscion
Copy link
Member

Released in v4.9.1 now ☺️. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants