Fix handling of webpack array configs #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This looks good to me, thank you! I'll merge once Travis CI happens to work again. |
|
Can you add a changelog entry? |
When trying to analyze a stats.json for a webpack bundle generated off of an array webpack.config.json webpack-bundle-analyzer was throwing: Could't analyze webpack bundle: TypeError: Cannot read property 'assets' of undefined This bug was probably introduced in webpack-contrib#376 Example webpack config to generate a stats.json file that causes the crash: ```js function getConfig({ config }) { return { mode: 'production', entry: './src/index.js', performance: { hints: 'warning', }, optimization: { minimize: true, }, output: { filename: `${config}-[name].js`, chunkFilename: `${config}-chunk-[name].js`, path: `${__dirname}/`, }, }; } module.exports = [{ config: 'config-1' }, { config: 'config-2' }].map(getConfig); ```
ctavan
force-pushed
the
fix-webpack-array-config
branch
from
7c59950
to
303d801
Compare
Done! |
|
Thanks! |
|
Released in v4.2.0 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to analyze a stats.json for a webpack bundle generated off
of an array webpack.config.json webpack-bundle-analyzer was throwing:
Could't analyze webpack bundle:
TypeError: Cannot read property 'assets' of undefined
This bug was probably introduced in
#376
Example webpack config to generate a stats.json file that causes the
crash: