Merge pull request #323 from lemonmade/fix-self-global-object

Allow self for globalObject in async chunks

CHANGELOG.md

@@ -14,6 +14,9 @@ _Note: Gaps between patch versions are faulty, broken or test releases._
 
 <!-- Add changelog entries for new changes under this section -->
 
+ * **Improvement**
+   * Support webpack builds where `output.globalObject` is set to `'self'` ([#323](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/323) by [@lemonmade](https://github.com/lemonmade))
+
 ## 3.5.2
 
  * **Bug Fix**

src/parseUtils.js

@@ -185,6 +185,8 @@ function isAsyncChunkPushExpression(node) {
     callee.object.left.object &&
     (
       callee.object.left.object.name === 'window' ||
+      // `self` is a common output.globalObject value used to support both workers and browsers
+      callee.object.left.object.name === 'self' ||
       // Webpack 4 uses `this` instead of `window`
       callee.object.left.object.type === 'ThisExpression'
     ) &&

test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.js

@@ -0,0 +1 @@
+(self.webpackJsonp=self.webpackJsonp||[]).push([[27],{1:function(e,n,t){console.log("Chuck Norris")}}]);

test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.modules.json

@@ -0,0 +1,5 @@
+{
+  "modules": {
+    "1": "function(e,n,t){console.log(\"Chuck Norris\")}"
+  }
+}