Drop static-serve, add comment

webpack-contrib · Dec 1, 2020 · 0f70814 · 0f70814
1 parent ab9f23d
commit 0f70814
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 27 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -41,7 +41,6 @@
     "gzip-size": "^6.0.0",
     "lodash": "^4.17.20",
     "opener": "^1.5.2",
-    "serve-static": "^1.14.1",
     "sirv": "^1.0.7",
     "ws": "^7.3.1"
   },

diff --git a/src/viewer.js b/src/viewer.js
@@ -49,6 +49,7 @@ async function startServer(bundleStats, opts) {
   if (!chartData) return;
 
   const sirvMiddleware = sirv(`${projectRoot}/public`, {
+    // disables caching and traverse the file system on every request
     dev: true
   });
 
@@ -64,16 +65,7 @@ async function startServer(bundleStats, opts) {
       res.writeHead(200, {'Content-Type': 'text/html'});
       res.end(html);
     } else {
-      sirvMiddleware(req, res, err => {
-        if (err) {
-          console.error(err.stack || err.toString());
-          res.writeHead(500);
-          res.end();
-        } else {
-          res.writeHead(404);
-          res.end();
-        }
-      });
+      sirvMiddleware(req, res);
     }
   });