Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

chore(package): update mime v1.3.6...2.0.0 #87

Merged
merged 1 commit into from Oct 2, 2017
Merged

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?
Chore

Did you add tests for your changes?

not required

If relevant, did you update the README?

not required

Summary

Ref: broofa/mime#168

Does this PR introduce a breaking change?

no

Other information

not required

@alexander-akait alexander-akait added this to the 0.5.10 milestone Sep 13, 2017
@michael-ciniawsky michael-ciniawsky changed the title chore: update mime package to avoid deprecation mime type with woff and woff2 chore(package): update mime v1.3.6...2.0.0 Sep 13, 2017
@ryanjadhav
Copy link

+1 thanks for updating!

@alexander-akait
Copy link
Member Author

@michael-ciniawsky why blocked?

@johntron
Copy link

Just FYI in case you're unaware - NSP published a security vulnerability in the mime package used by this project. According to npm, this package gets 178,618 downloads a day. I'm sure many people can benefit from some expediency in merging this PR.

@michael-ciniawsky
Copy link
Member

@evilebottnawi Requires node >= 6.0.0 😞

@joshwiens
Copy link
Member

joshwiens commented Sep 29, 2017

Publish as a Major & drop NodeJS 4.x support?

Taking this up with Tobias as this may be what needs to happen. Realistically, Node 4.x is EOL in April? of next year so we would be jumping the gun a bit but it's not that far off.

For those that are still on 4.x ( shouldn't be ) will have to use the existing version to retain 4.x support. It's a dev dep in 98% of the cases so the DDOS risk is minimal

@michael-ciniawsky
Copy link
Member

@d3viant0ne mime >= v1.4.1 should be fixed aswell

@joshwiens
Copy link
Member

Or that ^^

@joshwiens
Copy link
Member

joshwiens commented Sep 29, 2017

You will have to excuse me, i'm all for prodding people to use up to date Node versions when & wherever possible.

@evilebottnawi - Go with @michael-ciniawsky's suggestion and stick with the 1.4 version that has the DDOS fix.

@alexander-akait
Copy link
Member Author

@michael-ciniawsky @d3viant0ne done

@joshwiens joshwiens merged commit d19ee2d into master Oct 2, 2017
@joshwiens joshwiens deleted the update-mime branch October 2, 2017 17:24
@@ -9,7 +9,7 @@
},
"dependencies": {
"loader-utils": "^1.0.2",
"mime": "^1.3.6",
"mime": ">=1.4.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^1.4.1 😛

@michael-ciniawsky michael-ciniawsky removed this from the 0.6.1 milestone Oct 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants