This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
feat: custom minify function
#321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
reviewed
Jun 28, 2018
README.md
Outdated
| @@ -46,6 +46,7 @@ module.exports = { | |||
| |**`cache`**|`{Boolean\|String}`|`false`|Enable file caching| | |||
| |**`parallel`**|`{Boolean\|Number}`|`false`|Use multi-process parallel running to improve the build speed| | |||
| |**`sourceMap`**|`{Boolean}`|`false`|Use source maps to map error message locations to modules (This slows down the compilation) ⚠️ **`cheap-source-map` options don't work with this plugin**| | |||
| |**`minify`**|`{Function}`|`(file, uglifyOptions) => uglify.minify(file, uglifyOptions)`|Allows you to override default minify function| | |||
There was a problem hiding this comment.
The second param should be named differently
There was a problem hiding this comment.
seconded. (this repo could really benefit from a webpack-defaults update)
There was a problem hiding this comment.
uglifyOptions -> options?
There was a problem hiding this comment.
@ooflorent maybe better minifyOptions, because it will be misleading between options for plugin and options for minification
There was a problem hiding this comment.
yeah I could see that being a point of possible confusion
alexander-akait
force-pushed
the
feat-custom-minify-function
branch
from
05aa6e4
to
933e075
Compare
|
Close in favor #325 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use
uglify-jsandterser.Next steps:
webpack-defaults.terser., update tests and docs.nodejs@4).