Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated String.prototype.substr() #479

Merged
merged 2 commits into from
Jun 1, 2022
Merged

chore: replace deprecated String.prototype.substr() #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce74703
chore: replace deprecated String.prototype.substr()
CommanderRoot Mar 17, 2022
0a9cd14
Merge branch 'master' into rm-deprecated-substr
alexander-akait Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/index.js
View file
Open in desktop
Expand Up @@ -607,15 +607,15 @@ class TerserPlugin {
const querySplit = filename.indexOf("?");

if (querySplit >= 0) {
query = filename.substr(querySplit);
filename = filename.substr(0, querySplit);
query = filename.slice(querySplit);
filename = filename.slice(0, querySplit);
}

const lastSlashIndex = filename.lastIndexOf("/");
const basename =
lastSlashIndex === -1
? filename
: filename.substr(lastSlashIndex + 1);
: filename.slice(lastSlashIndex + 1);
const data = { filename, basename, query };

output.commentsFilename = compilation.getPath(
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/readAsset.js
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ export default (asset, compiler, stats) => {
const queryStringIdx = targetFile.indexOf("?");

if (queryStringIdx >= 0) {
targetFile = targetFile.substr(0, queryStringIdx);
targetFile = targetFile.slice(0, queryStringIdx);
}

try {
Expand Down