(fix): Pin the terser version #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terser `4.4.1` version is broken because of this: terser/terser#527 This PR pins the version to the latest one known that works correctly in order to avoid, well, breaking the building process of 1.4 milion people. :D
|
|
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 97.66% 99.12% +1.45%
==========================================
Files 5 5
Lines 343 343
Branches 144 144
==========================================
+ Hits 335 340 +5
+ Misses 8 3 -5
Continue to review full report at Codecov.
|
|
@midudev let's wait @fabiosantoscode ~24 hours before pinning |
|
Hey @evilebottnawi. While I would be the first to wait I consider that we could pin the version and, after fix, unpin again. And that would avoid lots of headaches for a lot of people. But, your call 👍 . |
|
The issue is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
terser
4.4.1version is broken because of this: terser/terser#527This PR pins the version to the latest one known that works correctly in order to avoid, well, breaking the building process of 1.4 milion people. :D
Breaking Changes
None. It's a unbreaking change.