Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(security): Add warning #615

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

xi
Copy link
Contributor

@xi xi commented Dec 6, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #613

Breaking Changes

--

Additional Info

I created these additions based on #613 (comment) by @alexander-akait. I hope this is what you had in mind.

Copy link

linux-foundation-easycla bot commented Dec 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xi / name: Tobias Bengfort (61c8d7d)

@evenstensberg
Copy link
Member

Could you sign the CLA?

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will LGTM after CLA is signed

@xi
Copy link
Contributor Author

xi commented Dec 7, 2023

CLA is signed

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd577b7) 89.96% compared to head (61c8d7d) 89.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files          15       15           
  Lines         329      329           
  Branches      170      170           
=======================================
  Hits          296      296           
  Misses         27       27           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xi
Copy link
Contributor Author

xi commented Dec 8, 2023

I fixed the commit message

@evenstensberg evenstensberg changed the title Add security warning Docs(security): Add warning Dec 8, 2023
@evenstensberg evenstensberg changed the title Docs(security): Add warning docs(security): Add warning Dec 8, 2023
@alexander-akait alexander-akait merged commit 14e731e into webpack-contrib:master Jan 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promotion of unsafe code
3 participants