fix: generate source maps using sass with asset/resource
#1010
Conversation
|
|
xoxys
changed the title
sass with asset/resourcesass with asset/resource
|
@alexander-akait How to handle the CLA? I mean, the commit was not done by me... |
|
You should not use another person PR, just send the same, CLA was assign by |
|
Why is my mailing address required to for the CLA? IMO a bit too much data that is requested. |
|
We use email from commits |
|
No Im talking about my postal address. The docusign document that need to be signed during the CLA process is asking for my private mailing/postal address... |
|
Very strange, it never asks it before, are you assign as |
|
Yes as an individual contributor: |
|
Just use the same email as you use in commit |
|
It is not the email address, there is a dedicated field for it, not shown in the screenshot. However, I've added |
|
How to proceed? Workflows need approvals I guess. |
|
@alexander-akait looks like it needs another approval |
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
+ Coverage 95.91% 95.97% +0.05%
==========================================
Files 5 5
Lines 294 323 +29
Branches 97 113 +16
==========================================
+ Hits 282 310 +28
- Misses 11 12 +1
Partials 1 1
Continue to review full report at Codecov.
|
|
There is interesting situation around #774, new compiler API fully remove all related source map options (i.e. only |
|
I think this goes a bit beyond my knowledge about how all works together :( |
|
yep, hard to find better solution here, only developer know location, maybe we should allow to modify CSS from Sass... |
This PR contains a:
Motivation / Use-Case
Supersedes: #968
Fixes: #962
Breaking Changes
No
Additional Info
No