fix: resolving .import

webpack-contrib · Dec 4, 2020 · 307b955 · 307b955
1 parent 4caf60f
commit 307b955
Show file tree

Hide file tree

Showing 11 changed files with 97 additions and 2 deletions.
diff --git a/src/utils.js b/src/utils.js
@@ -365,7 +365,7 @@ function getWebpackResolver(
       extensions: [".sass", ".scss", ".css"],
       exportsFields: [],
       mainFields: [],
-      mainFiles: ["_index", "index"],
+      mainFiles: ["_index.import", "_index", "index.import", "index"],
       modules: [],
       restrictions: [/\.((sa|sc|c)ss)$/i],
     })
@@ -374,7 +374,7 @@ function getWebpackResolver(
     resolverFactory({
       conditionNames: ["sass", "style"],
       mainFields: ["sass", "style", "main", "..."],
-      mainFiles: ["_index", "index", "..."],
+      mainFiles: ["_index.import", "_index", "index.import", "index", "..."],
       extensions: [".sass", ".scss", ".css"],
       restrictions: [/\.((sa|sc|c)ss)$/i],
     })

diff --git a/test/__snapshots__/loader.test.js.snap b/test/__snapshots__/loader.test.js.snap
@@ -1,5 +1,45 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`loader should import .import.sass files (dart-sass) (sass): css 1`] = `
+"a {
+  display: block;
+}"
+`;
+
+exports[`loader should import .import.sass files (dart-sass) (sass): errors 1`] = `Array []`;
+
+exports[`loader should import .import.sass files (dart-sass) (sass): warnings 1`] = `Array []`;
+
+exports[`loader should import .import.sass files from a package (dart-sass) (sass): css 1`] = `
+"a {
+  display: block;
+}"
+`;
+
+exports[`loader should import .import.sass files from a package (dart-sass) (sass): errors 1`] = `Array []`;
+
+exports[`loader should import .import.sass files from a package (dart-sass) (sass): warnings 1`] = `Array []`;
+
+exports[`loader should import .import.scss files (dart-sass) (scss): css 1`] = `
+"a {
+  display: block;
+}"
+`;
+
+exports[`loader should import .import.scss files (dart-sass) (scss): errors 1`] = `Array []`;
+
+exports[`loader should import .import.scss files (dart-sass) (scss): warnings 1`] = `Array []`;
+
+exports[`loader should import .import.scss files from a package (dart-sass) (scss): css 1`] = `
+"a {
+  display: block;
+}"
+`;
+
+exports[`loader should import .import.scss files from a package (dart-sass) (scss): errors 1`] = `Array []`;
+
+exports[`loader should import .import.scss files from a package (dart-sass) (scss): warnings 1`] = `Array []`;
+
 exports[`loader should load files with underscore in the name (dart-sass) (sass): css 1`] = `
 "a {
   color: red;

diff --git a/test/loader.test.js b/test/loader.test.js
@@ -1454,6 +1454,38 @@ describe("loader", () => {
           expect(getWarnings(stats)).toMatchSnapshot("warnings");
           expect(getErrors(stats)).toMatchSnapshot("errors");
         });
+
+        it(`should import .import.${syntax} files (${implementationName}) (${syntax})`, async () => {
+          const testId = getTestId("import-index-import", syntax);
+          const options = {
+            implementation: getImplementationByName(implementationName),
+          };
+          const compiler = getCompiler(testId, { loader: { options } });
+          const stats = await compile(compiler);
+          const codeFromBundle = getCodeFromBundle(stats, compiler);
+          const codeFromSass = getCodeFromSass(testId, options);
+
+          expect(codeFromBundle.css).toBe(codeFromSass.css);
+          expect(codeFromBundle.css).toMatchSnapshot("css");
+          expect(getWarnings(stats)).toMatchSnapshot("warnings");
+          expect(getErrors(stats)).toMatchSnapshot("errors");
+        });
+
+        it(`should import .import.${syntax} files from a package (${implementationName}) (${syntax})`, async () => {
+          const testId = getTestId("import-index-import-from-package", syntax);
+          const options = {
+            implementation: getImplementationByName(implementationName),
+          };
+          const compiler = getCompiler(testId, { loader: { options } });
+          const stats = await compile(compiler);
+          const codeFromBundle = getCodeFromBundle(stats, compiler);
+          const codeFromSass = getCodeFromSass(testId, options);
+
+          expect(codeFromBundle.css).toBe(codeFromSass.css);
+          expect(codeFromBundle.css).toMatchSnapshot("css");
+          expect(getWarnings(stats)).toMatchSnapshot("warnings");
+          expect(getErrors(stats)).toMatchSnapshot("errors");
+        });
       }
     });
   });

diff --git a/test/node_modules/index-import-package/_index.import.scss b/test/node_modules/index-import-package/_index.import.scss
diff --git a/test/node_modules/index-import-package/package.json b/test/node_modules/index-import-package/package.json
diff --git a/test/sass/import-index-import-from-package.sass b/test/sass/import-index-import-from-package.sass
@@ -0,0 +1 @@
+@import '~index-import-package'
diff --git a/test/sass/import-index-import.sass b/test/sass/import-index-import.sass
@@ -0,0 +1 @@
+@import 'index-import'
diff --git a/test/sass/index-import/_index.import.sass b/test/sass/index-import/_index.import.sass
@@ -0,0 +1,2 @@
+a
+  display: block
diff --git a/test/scss/import-index-import-from-package.scss b/test/scss/import-index-import-from-package.scss
@@ -0,0 +1 @@
+@import '~index-import-package';
diff --git a/test/scss/import-index-import.scss b/test/scss/import-index-import.scss
@@ -0,0 +1 @@
+@import 'index-import';
diff --git a/test/scss/index-import/_index.import.scss b/test/scss/index-import/_index.import.scss
@@ -0,0 +1,3 @@
+a {
+  display: block;
+}