test: support import index file from package (#649)

webpack-contrib · Dec 14, 2018 · 2d6045b · 2d6045b
1 parent aa64e1b
commit 2d6045b
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 0 deletions.
diff --git a/test/index.test.js b/test/index.test.js
@@ -173,6 +173,11 @@ implementations.forEach((implementation) => {
             ));
           it('should resolve sass field correctly', () =>
             execTest(`import-sass-field`));
+          // Works only in dart-sass implementation
+          if (implementation === dartSass) {
+            it('should resolve index file in module correctly', () =>
+              execTest('import-index'));
+          }
         });
         describe('custom importers', () => {
           it('should use custom importer', () =>

diff --git a/test/node_modules/sass-package-with-index/index.sass b/test/node_modules/sass-package-with-index/index.sass
diff --git a/test/node_modules/scss-package-with-index/index.scss b/test/node_modules/scss-package-with-index/index.scss
diff --git a/test/sass/import-index.sass b/test/sass/import-index.sass
@@ -0,0 +1 @@
+@import "~sass-package-with-index"
diff --git a/test/scss/import-index.scss b/test/scss/import-index.scss
@@ -0,0 +1 @@
+@import "~scss-package-with-index";
diff --git a/test/tools/createSpec.js b/test/tools/createSpec.js
@@ -113,6 +113,13 @@ function createSpec(ext) {
           return;
         }
 
+        if (fileWithoutExt === 'import-index' && implementation !== dartSass) {
+          // Skip CSS imports for all implementations that are not node-sass
+          // CSS imports is a legacy feature that we only support for node-sass
+          // See discussion https://github.com/webpack-contrib/sass-loader/pull/573/files?#r199109203
+          return;
+        }
+
         sassOptions.functions = customFunctions(implementation);
 
         const [name] = implementation.info.split('\t');