bug: add failing test for hashSalt in prod mode (realContentHash) #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting output.hashSalt together with optimization.realContentHash (e.g. prod mode) results in wrong urls for asset-modules, resulting in broken bundles. Added test seems to be minimum to reproduce.
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 6 6
Lines 704 704
Branches 170 170
=======================================
Hits 648 648
Misses 53 53
Partials 3 3 Continue to review full report at Codecov.
|
|
@wejendorp what is mini-css-extract-version? |
|
Yep, bug, we will try to fix it in near future |
Thank you for verifying @alexander-akait, let me know if I can help or anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
We noticed a bug with our bundles after adding salt values to the build.
Setting output.hashSalt together with optimization.realContentHash (e.g. prod mode)
results in wrong urls for asset-modules, resulting in broken bundles.
The added test seems to be minimum to reproduce. For context (sanity check), the naming issue
does not happen if the asset module is referenced from a js module instead.
Breaking Changes
None
Additional Info
This PR is just a bug report in the form of a failing test. I hope it can be useful to someone.