Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop normalize-url package #623

Merged
merged 7 commits into from
Oct 19, 2020

Conversation

cap-Bernardito
Copy link
Member

@cap-Bernardito cap-Bernardito commented Oct 16, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Drop normalize-url package

Breaking Changes

No

Additional Info

fixes #621

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #623 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   88.96%   89.34%   +0.38%     
==========================================
  Files          10       11       +1     
  Lines         616      638      +22     
  Branches      161      167       +6     
==========================================
+ Hits          548      570      +22     
  Misses         65       65              
  Partials        3        3              
Impacted Files Coverage Δ
src/hmr/hotModuleReplacement.js 90.74% <100.00%> (ø)
src/hmr/normalize-url.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a9ce9...a7af03a. Read the comment docs.

@cap-Bernardito cap-Bernardito force-pushed the refactor-drop-normalize-url-package branch from 06f4c6c to 6d58a5d Compare October 19, 2020 15:52
@cap-Bernardito cap-Bernardito force-pushed the refactor-drop-normalize-url-package branch from d45d340 to a7af03a Compare October 19, 2020 16:32
@alexander-akait alexander-akait merged commit 9ae47e5 into master Oct 19, 2020
@alexander-akait alexander-akait deleted the refactor-drop-normalize-url-package branch October 19, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normalize-url@1.9.1 dependency is not compatible with Webpack@5 out of the box
2 participants