feat: add stats option #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose a stats option to make hot module replacement and other informational messages optional. Only stat presets are supported but the API can be expanded to an object later if useful.
|
So far as I can tell, these errors are false positives due to preexisting security audit failures. |
alexander-akait
requested changes
Jun 11, 2020
|
Thank you for the fast feedback, @evilebottnawi! I'm sorry but I didn't quite understand the feedback. Are you saying to use the Webpack logger API, to abandon this change, or something else? Thank you! |
|
Yes webpack logger API |
|
@evilebottnawi, done (I think). Edit: I tried to mimic the webpack-dev-server implementation and options as the HMR client context is very similar. |
alexander-akait
requested changes
Jun 12, 2020
|
webpack-dev-server@4 migrate on built-in webpack logger |
|
@evilebottnawi, thank you. Is this a good example to base the approach on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Expose a stats option to make hot module replacement and other
informational messages optional. Only stat presets are supported but the
API can be expanded to an object later if useful.
Breaking Changes
Additional Info