Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new hook miniCssExtractPluginBeforeLinkAppend #514

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wangzongxu
Copy link

@wangzongxu wangzongxu commented Mar 22, 2020

Allow the link tag to be added to the head before doing some extra processing, such as I want to set a load timeout listener

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

As the link loads, I want to add code that controls the timeout

Breaking Changes

No

Additional Info

Allow the link tag to be added to the head before doing some extra processing, such as I want to set a load timeout listener
@jsf-clabot
Copy link

jsf-clabot commented Mar 22, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tests for it

@ankurbigcomm
Copy link

@wangzongxu Any update on this. This might be critical for one of our applications as well.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #514 (1c778c7) into master (b146549) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   88.55%   88.60%   +0.05%     
==========================================
  Files           5        5              
  Lines         428      430       +2     
  Branches       96       96              
==========================================
+ Hits          379      381       +2     
  Misses         47       47              
  Partials        2        2              
Impacted Files Coverage Δ
src/index.js 87.96% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b146549...1c778c7. Read the comment docs.

@wangzongxu
Copy link
Author

Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants