Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with webpack@4 and webpack@5 for monorepos #636

Merged
merged 1 commit into from Oct 22, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #600

Breaking Changes

No

Additional Info

hard to tests

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #636 into master will decrease coverage by 0.15%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   89.53%   89.37%   -0.16%     
==========================================
  Files          11       11              
  Lines         640      640              
  Branches      169      170       +1     
==========================================
- Hits          573      572       -1     
- Misses         64       65       +1     
  Partials        3        3              
Impacted Files Coverage Δ
src/index.js 91.10% <60.00%> (-0.43%) ⬇️
src/loader.js 91.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e7a0a...c5da573. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpackVersion check doesn't work if multiple versions of webpack are in use
1 participant