Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): fix compatibility with webpack@4 and webpack@5 for monorepos #12435

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

hardfist
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The current webpack version detect logic is flaw in monorepo with webpack@4 and webpack@5, webpack expose its version by compiler.webpack.version since webpack@5.1.0(webpack/webpack#11657 webpack@5.0.0 is the only exception), other webpack plugin meets the same problem, see webpack-contrib/mini-css-extract-plugin#636

@posva posva added this to Planned in 2.6.15 via automation Jan 24, 2022
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.6.15
Planned
Development

Successfully merging this pull request may close these issues.

None yet

3 participants