fix: schema (#652)

webpack-contrib · Nov 6, 2020 · 4e4733d · 4e4733d
1 parent be9ddcb
commit 4e4733d
Show file tree

Hide file tree

Showing 7 changed files with 100 additions and 9 deletions.
diff --git a/src/loader-options.json b/src/loader-options.json
@@ -1,6 +1,6 @@
 {
   "type": "object",
-  "additionalProperties": true,
+  "additionalProperties": false,
   "properties": {
     "publicPath": {
       "anyOf": [

diff --git a/src/plugin-options.json b/src/plugin-options.json
@@ -1,6 +1,6 @@
 {
   "type": "object",
-  "additionalProperties": true,
+  "additionalProperties": false,
   "properties": {
     "filename": {
       "anyOf": [

diff --git a/test/__snapshots__/validate-loader-options.test.js.snap b/test/__snapshots__/validate-loader-options.test.js.snap
@@ -25,3 +25,51 @@ exports[`validate options should throw an error on the "publicPath" option with
     * options.publicPath should be a string.
     * options.publicPath should be an instance of function."
 `;
+
+exports[`validate options should throw an error on the "unknown" option with "/test/" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "[]" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "{"foo":"bar"}" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "{}" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "1" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "false" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "test" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "true" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin Loader has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { publicPath?, esModule?, modules? }"
+`;
diff --git a/test/__snapshots__/validate-plugin-options.test.js.snap b/test/__snapshots__/validate-plugin-options.test.js.snap
@@ -95,3 +95,51 @@ exports[`validate options should throw an error on the "linkType" option with "i
     * options.linkType should be \\"text/css\\".
     * options.linkType should be a boolean."
 `;
+
+exports[`validate options should throw an error on the "unknown" option with "/test/" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "[]" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "{"foo":"bar"}" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "{}" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "1" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "false" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "test" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
+
+exports[`validate options should throw an error on the "unknown" option with "true" value 1`] = `
+"Invalid options object. Mini CSS Extract Plugin has been initialized using an options object that does not match the API schema.
+ - options has an unknown property 'unknown'. These properties are valid:
+   object { filename?, chunkFilename?, ignoreOrder?, insert?, attributes?, linkType? }"
+`;
diff --git a/test/cases/js-hash/webpack.config.js b/test/cases/js-hash/webpack.config.js
@@ -10,9 +10,6 @@ module.exports = [1, 2].map((n) => {
           use: [
             {
               loader: Self.loader,
-              options: {
-                hmr: false,
-              },
             },
             {
               loader: 'css-loader',

diff --git a/test/validate-loader-options.test.js b/test/validate-loader-options.test.js
@@ -16,8 +16,7 @@ describe('validate options', () => {
     },
     unknown: {
       success: [],
-      // TODO failed in next release
-      // failure: [1, true, false, 'test', /test/, [], {}, { foo: 'bar' }],
+      failure: [1, true, false, 'test', /test/, [], {}, { foo: 'bar' }],
     },
   };
 

diff --git a/test/validate-plugin-options.test.js b/test/validate-plugin-options.test.js
@@ -38,8 +38,7 @@ describe('validate options', () => {
     },
     unknown: {
       success: [],
-      // TODO failed in next release
-      // failure: [1, true, false, 'test', /test/, [], {}, { foo: 'bar' }],
+      failure: [1, true, false, 'test', /test/, [], {}, { foo: 'bar' }],
     },
   };