This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat: allow to log invalid orders as warnings instead of errors via option #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
any objections @sokra? |
|
we really would like to see this merged. can you please have a look? |
|
👍 |
joshwiens
force-pushed
the
master
branch
2 times, most recently
from
664e78c
to
76a171d
Compare
michael-ciniawsky
changed the title
michael-ciniawsky
suggested changes
Jun 20, 2017
| @@ -284,8 +284,9 @@ ExtractTextPlugin.prototype.apply = function(compiler) { | |||
| if(extractedChunk.modules.length) { | |||
| extractedChunk.modules.sort(function(a, b) { | |||
| if(isInvalidOrder(a, b)) { | |||
| compilation.errors.push(new OrderUndefinedError(a.getOriginalModule())); | |||
| compilation.errors.push(new OrderUndefinedError(b.getOriginalModule())); | |||
| var targetLog = options.relaxInvalidOrder ? compilation.warnings : compilation.errors; | |||
There was a problem hiding this comment.
This could go hand in hand with the ignoreOrder option, instead of adding a new option
There was a problem hiding this comment.
Happy to adapt the PR @michael-ciniawsky
There was a problem hiding this comment.
@joscha Yep please go ahead, not 💯 my assumption is yet fully correct :)
|
We are close to a major release, currently in |
michael-ciniawsky
added
status: Declined
and removed
pr_action: Blocked
semver: Minor
type: Feature
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating from a large legacy codebase to Webpack, we noticed that many of our CSS group definitions have inconsistent ordering. After trying to fix that ordering for a while, we found out that it was actually not that simple. Especially because the order might be deliberately different per entry-point and there was no way of knowing that without asking the author(s) of the respective CSS group.
The build with the
extract-text-pluginwould still generate the correct (in the sense of the definition given by the developers) output, except the CI would fail because webpack would exit with a non-zero state because of the order "errors".Therefore we introduced an option to the plugin that allows us to degrade those errors to warnings, which makes the developers aware of their inconsistent ordering without breaking the CI build immediately.
fixes #80
cc @joscha