This repository has been archived by the owner on May 29, 2019. It is now read-only.
refactor(loader): do not throw errors in case of child context #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| '"extract-text-webpack-plugin" loader is used without the corresponding plugin, ' + | ||
| 'refer to https://github.com/webpack/extract-text-webpack-plugin for the usage example', | ||
| ); | ||
| } else if (this[NS] === false) { |
There was a problem hiding this comment.
Why emit warning on false?
michael-ciniawsky
changed the title
michael-ciniawsky
suggested changes
Feb 28, 2018
There was a problem hiding this comment.
I'm declining this for now as it is stalled and would need to be reopen/rebased against the next branch to land. extract-text-plugin-webpack-plugin will be superseded by another solution in then near future (native CSS support (module.type), `css-webpack-plugin (WIP)) and only receives critical fixes atm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm resubmitting the PR on behalf of the original contributor #390. They originally were asked to do it after #540 hit master which it has. The original contributor hasn't submitted the PR but I'd like to be using the master version of extract-text-plugin with the patch.
This basically changes the error on child context to a warning. The use case is when using extract-text-plugin with html-webpack-plugin to pull css into its own file at compilation time, same as the original #390. I've applied the same commit on master and been using it in my own fork since it hasn't been merged yet.