Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix: corrected order for chunk.modules #563

Conversation

hulkish
Copy link

@hulkish hulkish commented Jul 6, 2017

note: After speaking to Tobias, a sort function will be added in Webpack so we don't need to contend with module internals in the plugin.

  • fix: CSS Generated in the wrong order with Webpack 3.0.0

reproducible project https://github.com/cyl19910101/wp3_test

Fixes #548. Is blocked by webpack/webpack#5225

@codecov
Copy link

codecov bot commented Jul 6, 2017

Codecov Report

Merging #563 into feature/webpack3 will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feature/webpack3     #563      +/-   ##
====================================================
+ Coverage             87.37%   87.74%   +0.37%     
====================================================
  Files                     7        7              
  Lines                   301      302       +1     
  Branches                 68       68              
====================================================
+ Hits                    263      265       +2     
+ Misses                   36       35       -1     
  Partials                  2        2
Impacted Files Coverage Δ
src/index.js 89.7% <100%> (+0.07%) ⬆️
src/loader.js 90.32% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10721f5...dde5896. Read the comment docs.

@hulkish
Copy link
Author

hulkish commented Jul 6, 2017

@joshwiens
Copy link
Member

joshwiens commented Jul 7, 2017

This fix needs to be based off of and merged into feature/webpack3.

etwp 3.x contains breaking changes that make it webpack 3.x only.

@hulkish hulkish changed the base branch from master to feature/webpack3 July 7, 2017 01:07
@hulkish hulkish force-pushed the fix/correct-chunk-module-order branch 2 times, most recently from 24e6eb3 to 7723e3a Compare July 7, 2017 01:22
@hulkish
Copy link
Author

hulkish commented Jul 7, 2017

@d3viant0ne done

@joshwiens joshwiens changed the title corrected order for chunk.modules loop fix: corrected order for chunk.modules Jul 7, 2017
@joshwiens joshwiens requested a review from bebraw July 7, 2017 04:49
@joshwiens joshwiens merged commit 5a23fc0 into webpack-contrib:feature/webpack3 Jul 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants