This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix: corrected order for chunk.modules #563
Merged
joshwiens
merged 4 commits into
webpack-contrib:feature/webpack3
from
hulkish:fix/correct-chunk-module-order
Jul 7, 2017
Merged
fix: corrected order for chunk.modules #563
joshwiens
merged 4 commits into
webpack-contrib:feature/webpack3
from
hulkish:fix/correct-chunk-module-order
Jul 7, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/webpack3 #563 +/- ##
====================================================
+ Coverage 87.37% 87.74% +0.37%
====================================================
Files 7 7
Lines 301 302 +1
Branches 68 68
====================================================
+ Hits 263 265 +2
+ Misses 36 35 -1
Partials 2 2
Continue to review full report at Codecov.
|
Hmm.. not sure what to do about this https://travis-ci.org/webpack-contrib/extract-text-webpack-plugin/jobs/250950397 |
This fix needs to be based off of and merged into etwp 3.x contains breaking changes that make it webpack 3.x only. |
hulkish
force-pushed
the
fix/correct-chunk-module-order
branch
2 times, most recently
from
July 7, 2017 01:22
24e6eb3
to
7723e3a
Compare
@d3viant0ne done |
joshwiens
changed the title
corrected order for chunk.modules loop
fix: corrected order for chunk.modules
Jul 7, 2017
bebraw
approved these changes
Jul 7, 2017
joshwiens
approved these changes
Jul 7, 2017
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548. Is blocked by webpack/webpack#5225