Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

fix module build failed error at Linter.parseResults #294

Merged
merged 4 commits into from Sep 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Linter.js
Expand Up @@ -113,10 +113,12 @@ export default class Linter {

parseResults({ results }) {
// add filename for each results so formatter can have relevant filename
results.forEach((r) => {
// eslint-disable-next-line no-param-reassign
r.filePath = this.loaderContext.resourcePath;
});
if (results) {
results.forEach((r) => {
// eslint-disable-next-line no-param-reassign
r.filePath = this.loaderContext.resourcePath;
});
}

return results;
}
Expand Down
24 changes: 24 additions & 0 deletions test/Linter.test.js
@@ -0,0 +1,24 @@
import Linter from '../src/Linter';

const loaderContext = { resourcePath: 'test' };
const options = {
eslintPath: 'eslint',
ignore: false,
formatter: jest.fn(),
};
const res = { results: [{ filePath: '' }] };

describe('Linter', () => {
let linter;
beforeAll(() => {
linter = new Linter(loaderContext, options);
});

it('should parse undefined results without error', () => {
expect(linter.parseResults({})).toBeUndefined();
});

it('should parse results correctly', () => {
expect(linter.parseResults(res)).toEqual([{ filePath: 'test' }]);
});
});