fix module build failed error at Linter.parseResults

[buihdk]

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

Motivation / Use-Case

I am using the latest eslint-loader v3.0.0 on my rejected create-react-app and encountered this issue when I tried to start the app: TypeError: Cannot read property 'forEach' of undefined. This is the fix for this error.

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Khoa Bui Hoang Dang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

[codecov]

Codecov Report

Merging #294 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #294   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         133    134    +1     
  Branches       27     28    +1     
=====================================
+ Hits          133    134    +1

Impacted Files	Coverage Δ
src/Linter.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4895987...6211567. Read the comment docs.

[ricardogobbosouza]

@buihdk fix messages of commits, CI is not passing.

type(subject?): message

try:

fix: module build failed error at Linter.parseResults

[alexander-akait]

Can we add tests?

[buihdk]

Can we add tests?

Do you want end-to-end tests or just unit tests i.e. I'll add a Linter.test.js file to cover specific cases for above issue.

[alexander-akait]

@buihdk unit tests enough

[ricardogobbosouza]

@evilebottnawi I don't have permission to merge 😞

[alexander-akait]

@ricardogobbosouza strange, you have write, what is github writes to you?

[ricardogobbosouza]

@evilebottnawi You’re not authorized to merge this pull request.

[alexander-akait]

@ricardogobbosouza let's investigate this situation, i want to add permissions on merge and release

[alexander-akait]

@ricardogobbosouza Can you check again?

[alexander-akait]

/cc @ricardogobbosouza can you give npm username?

[ricardogobbosouza]

@evilebottnawi sure, its same ricardogobbosouza

[alexander-akait]

@ricardogobbosouza please enable 2FA

[ricardogobbosouza]

@evilebottnawi enabled

[alexander-akait]

@ricardogobbosouza now you can do release:

1. npm run release
2. check CHANGELOG.md is good and you have new tag (npm run release do this automatically, just manual checking)
3. push release commit to master and push new tag
4. fill release (https://github.com/webpack-contrib/eslint-loader/releases), just copy/paste from CHANGELOG.md
5. run npm publish

[ricardogobbosouza]

@evilebottnawi thanks

[misha-panyushkin]

@evilebottnawi @ricardogobbosouza hey man! how is it going with releasing bugfix?

P.S. I will appreciate your new release with this fix. 🙏 Actually need your attention at the moment
thanks a lot

[alexander-akait]

@misha-panyushkin near future