Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1384 #1385

Merged
merged 3 commits into from Oct 9, 2021
Merged

Issue 1384 #1385

merged 3 commits into from Oct 9, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1384

Breaking Changes

No

Additional Info

We should not rely on matchResource

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #1385 (b2f7194) into master (c7db752) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1385      +/-   ##
==========================================
- Coverage   98.43%   98.43%   -0.01%     
==========================================
  Files          12       12              
  Lines        1088     1085       -3     
  Branches      375      374       -1     
==========================================
- Hits         1071     1068       -3     
  Misses         14       14              
  Partials        3        3              
Impacted Files Coverage Δ
src/utils.js 97.64% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7db752...b2f7194. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR: generated class names are not consistent for client and server bundles since v5.1.3
1 participant