Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow named exports to have underscores in names #1209

Merged
merged 3 commits into from
Oct 13, 2020

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #1206

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #1209 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1209   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          11       11           
  Lines         679      685    +6     
  Branches      218      221    +3     
=======================================
+ Hits          675      681    +6     
  Misses          4        4           
Impacted Files Coverage Δ
src/utils.js 98.75% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bfe85d...f9f3cc0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow named exports to have underscores in names
3 participants