Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat update css modules plugins #1205

Closed
wants to merge 4 commits into from

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Oct 8, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Update plugins

Breaking Changes

Yes

Additional Info

Problems:

  • need migrate on OnceExit for all plugins WIP
  • more perf improvements in plugins
  • one regression with url and @value, I think we need to fix it in plugin

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1205 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
+ Coverage   99.18%   99.26%   +0.07%     
==========================================
  Files          22       11      -11     
  Lines        1356      678     -678     
  Branches      441      220     -221     
==========================================
- Hits         1345      673     -672     
+ Misses         11        5       -6     
Impacted Files Coverage Δ
D:/a/css-loader/css-loader/src/utils.js
...er/css-loader/src/plugins/postcss-import-parser.js
...ader/css-loader/src/plugins/postcss-icss-parser.js
D:/a/css-loader/css-loader/src/runtime/api.js
D:/a/css-loader/css-loader/src/index.js
...oader/css-loader/src/plugins/postcss-url-parser.js
...r/css-loader/src/runtime/cssWithMappingToString.js
D:/a/css-loader/css-loader/src/cjs.js
D:/a/css-loader/css-loader/src/Warning.js
D:/a/css-loader/css-loader/src/CssSyntaxError.js
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c9379...1c82d5d. Read the comment docs.

@alexander-akait
Copy link
Member Author

Close in favor #1208

@alexander-akait alexander-akait deleted the feat-update-css-modules-plugins branch October 11, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant